DRPLDCX-99 Collections #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrfritsch
reviewed
Oct 19, 2016
| public function getPreview($id) { | ||
| $json = NULL; | ||
|
|
||
| if ($params == NULL) { |
There was a problem hiding this comment.
True. It's safe to remove the if clause.
| 'q' => [ | ||
| '_mode' => 'my_usertags', | ||
| 'type_id' => 'usertagtype-default', | ||
| 'parent_id#NULL' => $parent_id, |
There was a problem hiding this comment.
$parent_id is always undefined
There was a problem hiding this comment.
Refering to the docs Thorsten Behn sent me $parent_id is supposed to be an empty string. Just replace it with "".
|
I have created a 8.x-2.x into module-dcx-integration for D8.2 compatibility. I have also updated the staging env. So please use the dcx branch of https://github.com/BurdaMagazinOrg/project-dcx-integration |
chrfritsch
force-pushed
the
DRPLDCX-99/collections
branch
from
60f28e8 to
821eede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrate DC-X collections on the entity browser for images.
It only provides "own" collections, as the DC-X API only supports these atm.
The process is rather complicated as there is a lot of communication with DC-X involved:
STR: